-
Notifications
You must be signed in to change notification settings - Fork 1
Added readme #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added readme #3
Conversation
|
Would be interested to hear if @kshitijrajsharma is ok with But then again, osm_data_client is a bit more user friendly, soooo Perhaps raw-data-api would be better named with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice!
We can probably get integrating this into FieldTM immediately 😄
|
Actually something I forgot to mention in the requirements is the possibility of uploading a YAML config via the Example of supported YAMLs: https://github.com/hotosm/osm-fieldwork/tree/main/osm_fieldwork/data_models Previously we were parsing the YAML --> JSON format for sending to raw-data-api in a package osm-rawdata. What I think we should do:
|
|
Not that picky with the naming , I am assuming you might need rafactor but usually the descriptive naming of the tool I find it more useful , raw-data-api-py would be descriptive |
|
Will review and merge this asap - just back from holidays 👍 |
|
Actually I just realised that's not the package name, but just the import name. I'm happy with raw-data-api-py being the published package, but importing in code as I'll publish it now 😄 |
This PR:
Also, I just realized that in my head I started calling the package "osm_data_client" and named everything accordingly.
Thoughts on that ?